Fix OSS build failures #572
Closed
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these changes, the build fails with unresolved symbol failures. Presumably, this is because `dns/CAresResolver.cpp` and `dns/CachingDNSResolver.cpp` are referenced in other files that are being compiled. We then need to link `cares` because it is used in the two files added to `PROXYGEN_CORO_SOURCES`. Finally, we need to replace the `#error` macro with a `static_assert`, because (at least as of `c-ares` version `1.34.5`) `ARES_SUCCESS` and `ARES_EREFUSED` are `enum` constants, and therefore not visible to the preprocessor. We also drop the reference to `TraceFieldType::TXT` because this reference doesn't seem to be generated at build time, presumably because this is not a type included in `lib/utils/samples/TraceFieldType.txt`.
|
@carlocab thanks, this solves the build-tests option as well |
Contributor
|
@hanidamlaj has imported this pull request. If you are a Meta employee, you can view this in D81097087. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Aug 30, 2025
Summary: Without these changes, the build fails with unresolved symbol failures. Presumably, this is because `dns/CAresResolver.cpp` and `dns/CachingDNSResolver.cpp` are referenced in other files that are being compiled. We then need to link `cares` because it is used in the two files added to `PROXYGEN_CORO_SOURCES`. Finally, we need to replace the `#error` macro with a `static_assert`, because (at least as of `c-ares` version `1.34.5`) `ARES_SUCCESS` and `ARES_EREFUSED` are `enum` constants, and therefore not visible to the preprocessor. We also drop the reference to `TraceFieldType::TXT` because this reference doesn't seem to be generated at build time, presumably because this is not a type included in `lib/utils/samples/TraceFieldType.txt`. Fixes facebook/proxygen#573 X-link: facebook/proxygen#572 Reviewed By: lnicco Differential Revision: D81097087 Pulled By: hanidamlaj fbshipit-source-id: 7ed331685fd9c7743b7fcc9be7807e0f48db4019
Contributor
|
@hanidamlaj merged this pull request in a238ec5. |
mszabo-wikia
added a commit
to mszabo-wikia/proxygen
that referenced
this pull request
Sep 22, 2025
List input files as dependencies for add_custom_command() calls. This avoids failures in incremental builds if e.g. TraceFieldType.txt changes, since CMake will be able to mark the output as out of date and regenerate it as needed. Follows-up facebook#572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes, the build fails with unresolved symbol failures.
Presumably, this is because
dns/CAresResolver.cppanddns/CachingDNSResolver.cppare referenced in other files that arebeing compiled.
We then need to link
caresbecause it is used in the two files addedto
PROXYGEN_CORO_SOURCES.Finally, we need to replace the
#errormacro with astatic_assert,because (at least as of
c-aresversion1.34.5)ARES_SUCCESSandARES_EREFUSEDareenumconstants, and therefore not visible to thepreprocessor.
We also drop the reference to
TraceFieldType::TXTbecause thisreference doesn't seem to be generated at build time, presumably because
this is not a type included in
lib/utils/samples/TraceFieldType.txt.Fixes #573