-
Notifications
You must be signed in to change notification settings - Fork 285
Labels
typecheckingv1-consider-addingTop-ranked but not in V1 milestone (consider adding)Top-ranked but not in V1 milestone (consider adding)
Milestone
Description
Describe the Bug
If a module's __all__ attribute contains a name that pyrefly can't resolve, it reports a bad-dunder-all error on the __all__ definition, then a missing-module-attribute error on a star-import of the module.
IMO we shouldn't report the latter: it may not be actionable (if you're importing from a third-party library, it's not easy to go in and fix __all__), and it's redundant with the bad-dunder-all error.
Sandbox Link
(Only applicable for extension issues) IDE Information
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
typecheckingv1-consider-addingTop-ranked but not in V1 milestone (consider adding)Top-ranked but not in V1 milestone (consider adding)