Skip to content

Using a Literal key to update values in a TypeDict #329

@cscanlin

Description

@cscanlin

Describe the Bug

I'm not sure how exactly to describe this, but it isn't working as I expect.

Even though I have guarded my key variable with a Literal, pyrefly does not seem to respect the None check.

This works as expected when my key is the actual string.

from typing import Any, TypedDict, Literal

class MyDict(TypedDict):
    my_key: list[str] | None


def fun1():
    data: MyDict = {'my_key': None}
    if data['my_key'] is None:
        data['my_key'] = []
    else:
        data['my_key'].append('data')


def fun2():
    data: MyDict = {'my_key': None}
    key: Literal['my_key'] = 'my_key'

    if data[key] is None:
        data[key] = []
    else:
        data[key].append('data')  # this fails
        data['my_key'].append('data')  # also fails

Sandbox Link

https://pyrefly.org/sandbox/?code=GYJw9gtgBALgngBwJYDsDmUkQWEMoCCKcANFACqICmAJgCJIDGMZAMkjFSAIYA2AUP0a9uAZ1FQAsnAbMAFJQS1ZMAJQAuflG1QIcAPoBrKnHVReSUTADaVkAF0oAHygA5MCiqD+NKsCjAAK4oAIxyGlo6NNww3GbSKlAAvFAA3gDkekYm6WbungC+kdpI-tGx1pkGxnDpjpZuHlSaOq1Q5dyVWTV1yVDW9sVQVLyizUOtHV3VOfYAdNwISig0cukd6arevv5BKABM4S1RMXFSMkz4KRndOXlNRa01ZuycPLzT2bWOKVVf6YJWqV2qdrDV6hJ8uM2icKuC+gMhiMxscYVNwQsllQVmsNqptABiWAACwawG4SFGE1hnT+PXmi2Wq3Wp02hKgfFEYACFKpQA

(Only applicable for extension issues) IDE Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    userBugs reported by external users that should be prioritised

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions