fix false positive missing override decorator error#2388
Closed
yangdanny97 wants to merge 1 commit intofacebook:mainfrom
Closed
fix false positive missing override decorator error#2388yangdanny97 wants to merge 1 commit intofacebook:mainfrom
yangdanny97 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: fixes facebook#2375 Reviewed By: stroxler Differential Revision: D92838784
|
@yangdanny97 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92838784. |
stroxler
approved these changes
Feb 12, 2026
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
This pull request has been merged in 6cc2bbb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: fixes #2375
Reviewed By: stroxler
Differential Revision: D92838784