This repository was archived by the owner on Jun 26, 2020. It is now read-only.
[chrome] hide highlight when switching devtools tab#116
Merged
jaredly merged 1 commit intodevtools-nextfrom Aug 5, 2015
Merged
[chrome] hide highlight when switching devtools tab#116jaredly merged 1 commit intodevtools-nextfrom
jaredly merged 1 commit intodevtools-nextfrom
Conversation
jaredly
changed the title
Contributor
Author
There was a problem hiding this comment.
It sends a message to the agent (living on the page) to hide the highlight
Contributor
There was a problem hiding this comment.
Got it, of course. Does anything listen to the emit('hover')?
Contributor
Author
There was a problem hiding this comment.
Yeah -- here's the file used to connect a Highlighter to an Agent
Contributor
There was a problem hiding this comment.
I think you misread my question?
Contributor
Author
There was a problem hiding this comment.
oh yes! I totally did. No, nothing listens for hover at the moment. Would you rather I remove it?
jaredly
added a commit
that referenced
this pull request
Aug 5, 2015
[chrome] hide highlight when switching devtools tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Elements pane will hide its highlight if you go to a different devtools tab, and I think that behavior makes more sense.
This is what happens w/ this PR: