Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Conversation

@jaredly
Copy link
Contributor

@jaredly jaredly commented Aug 12, 2015

Before this change, both Native and NativeWrapper components were showing up in listings under 0.13.
We want to only display NativeWrappers in 0.13, but in 0.14 there are no native wrappers, so we just show the native components.

Before:
image

After:
image

(half as many native components shown)

@sophiebits
Copy link
Contributor

Why can't we always show the Native component, sorry? I'm failing to remember what NativeWrappers are at all.

@jaredly
Copy link
Contributor Author

jaredly commented Aug 12, 2015

It's the 0.13 wrapper around divs, etc.
We can't just show the native component, b/c they have immutable props, and the current devtools allow props mutation for native components in 0.13

If we drop 0.13 support at some time in the future, we can remove the NativeWrapper stuff

@sophiebits
Copy link
Contributor

Oh, on web. All right.

jaredly added a commit that referenced this pull request Aug 12, 2015
@jaredly jaredly merged commit 412073d into facebook:devtools-next Aug 12, 2015
@jaredly jaredly deleted the fix-search-results branch August 12, 2015 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants