Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

add a plugin to trace react updates #297

Merged
sebmarkbage merged 31 commits intofacebook:masterfrom
hedgerwang:banana_slug
Jan 4, 2016
Merged

add a plugin to trace react updates #297
sebmarkbage merged 31 commits intofacebook:masterfrom
hedgerwang:banana_slug

Conversation

@hedgerwang
Copy link
Copy Markdown

Add a plugin (codename: bananaslug) to highlight react updates in page.
See https://github.com/hedgerwang/react-devtools/tree/banana_slug/demo for demo and details.

@jimfb
Copy link
Copy Markdown

jimfb commented Dec 14, 2015

This is a very cool feature, we should figure out how to get it merged.

@spicyj, since you know the devtools best, can you take a look?

@hedgerwang
Copy link
Copy Markdown
Author

cc @sebmarkbage @jordwalke

@sophiebits
Copy link
Copy Markdown
Contributor

Do you think you could take a look at this @jaredly?

@jaredly
Copy link
Copy Markdown
Contributor

jaredly commented Dec 15, 2015

sure thing

@kassens
Copy link
Copy Markdown
Member

kassens commented Dec 18, 2015

@hedgerwang If you have flow installed on your computer you should be able to just run flow in the main directory. Otherwise node_modules/.bin/flow should do the trick. (flow also runs on Travis, so it should be all good)

@hedgerwang
Copy link
Copy Markdown
Author

@jaredly : flow check was added. please have another look. thanks.

@hedgerwang
Copy link
Copy Markdown
Author

ping :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_toggle?

@jaredly
Copy link
Copy Markdown
Contributor

jaredly commented Dec 29, 2015

This is so awsome!
could you remove the demo directory, and add firefox support? then I think it'll be ready to go

@hedgerwang
Copy link
Copy Markdown
Author

@jaredly

I've removed the demo directory and added the firefox support.
Please have another look :)

@jaredly
Copy link
Copy Markdown
Contributor

jaredly commented Dec 29, 2015

looks like it needs a rebase, and then it's great!
@jimfb after the rebase, we should be all set

@jimfb
Copy link
Copy Markdown

jimfb commented Dec 29, 2015

Ok, great, thanks @jaredly!

Hedger Wang added 2 commits December 29, 2015 10:40
@hedgerwang
Copy link
Copy Markdown
Author

@jimfb, @jaredly : I've done the rebase work. Let's ship it!

@hedgerwang
Copy link
Copy Markdown
Author

happy new year!
any chance that we could land this?

@sebmarkbage
Copy link
Copy Markdown
Contributor

Did you test it with React Native so the UI doesn't break there? In other news, does the devtools work in React Native again? Anyway. I'll merge and then we'll see what happens.

sebmarkbage added a commit that referenced this pull request Jan 4, 2016
add a plugin to trace react updates
@sebmarkbage sebmarkbage merged commit 68a71d3 into facebook:master Jan 4, 2016
@sophiebits
Copy link
Copy Markdown
Contributor

In other news, does the devtools work in React Native again?

No. :( #229

@hedgerwang
Copy link
Copy Markdown
Author

@sebmarkbage : there is no implementation in RN so this feature is disabled in RN.

@hedgerwang
Copy link
Copy Markdown
Author

Thanks everyone who helped to review this.

One more question:
Is there anything that I should do to land the new extension to web store?

Thanks.

@huang47
Copy link
Copy Markdown

huang47 commented Jan 14, 2016

this is awesome, just can't wait! :D

@gaearon
Copy link
Copy Markdown
Contributor

gaearon commented Jan 12, 2017

Every time I read the source I forget what "banana slug" means.
😞

@sophiebits
Copy link
Copy Markdown
Contributor

@gaearon Feel free to rename. :) RerenderIndicator

@hedgerwang
Copy link
Copy Markdown
Author

@gaearon : Banaslug is a lovely creature that moves slowly and leaves visible trace on the ground.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants