Skip to content

Conversation

vzaidman
Copy link

@vzaidman vzaidman commented Oct 13, 2025

Summary

When a memory heap snapshot is created, it is being retrieved before it's parsing is complete.

Test plan

Slow down parseInput by adding:

    await new Promise(resolve => setTimeout(resolve, 3000));

As the first line of that function to ensure the race condition always resolves with a crash.

Before:

before2.mov

After:

after.mov
  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this finally 👏🏻

@huntie huntie merged commit 54afd87 into main Oct 13, 2025
5 checks passed
@huntie huntie deleted the fix-memory-profiling-race-condition branch October 13, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants