Updated docs to reflect exceptions when using the Linking API in Simulator#1295
Merged
Conversation
|
Deploy preview for react-native ready! Built with commit b47a65d https://deploy-preview-1295--react-native.netlify.com Changes to Thank you for your contributions. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 30, 2019
Summary: This PR, tries to fix the problem at #26554 ## Changelog iOS Fixed - Now it will show a warning when trying to use it inside a simulator, instead of throwing a red screen error. ## Notes Docs PR opened as well at: facebook/react-native-website#1295 <img width="418" alt="image" src="https://user-images.githubusercontent.com/12865914/65734976-532ebc00-e0cd-11e9-8e8c-2b4a5a7b8aea.png"> Pull Request resolved: #26607 Differential Revision: D17661091 Pulled By: cpojer fbshipit-source-id: 3d660f25546374adfa3436e2954c9c27750039b7
charpeni
approved these changes
Oct 11, 2019
Contributor
charpeni
left a comment
There was a problem hiding this comment.
Thanks, let's wait on the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the docs after this PR:
facebook/react-native#26607