Skip to content

Consolidate native dependencies versions#20742

Closed
dulmandakh wants to merge 1 commit intofacebook:masterfrom
dulmandakh:native-deps-versions
Closed

Consolidate native dependencies versions#20742
dulmandakh wants to merge 1 commit intofacebook:masterfrom
dulmandakh:native-deps-versions

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

This PR tries to consolidate Android native dependencies versions to make it less error prone to version bumps.

Test Plan:

CI is green

@dulmandakh dulmandakh requested review from fkgozali and hramos August 20, 2018 04:13
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 20, 2018
apply plugin: 'maven'

apply plugin: 'de.undercouch.download'
plugins {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think old-fashioned is good and more readable.

@dulmandakh
Copy link
Copy Markdown
Contributor Author

dulmandakh commented Aug 20, 2018 via email

@gengjiawen
Copy link
Copy Markdown
Contributor

Yes, but most project like butter-knife and rxjava use the old-fashioned way. I think kotlin dsl still has a long way to go. Even sqldelight and okio which written in kotlin use the old-fasioned way too https://github.com/square/sqldelight/blob/master/sqldelight-core/build.gradle.

@dulmandakh
Copy link
Copy Markdown
Contributor Author

dulmandakh commented Aug 20, 2018 via email

@gengjiawen
Copy link
Copy Markdown
Contributor

I think the old way is more readable. And adopt to new kotlin dsl we can wait for google officially support it. No need to rush to new syntax since few people using it.

@FibreFoX
Copy link
Copy Markdown

Instead of following "other peoples recommendations", does using plugin-block fix something? If not, then why change?

@dulmandakh
Copy link
Copy Markdown
Contributor Author

@hramos please review and merge. plugins block is recommended way to configure Gradle plugins and I found it's used in fresco.

@dulmandakh
Copy link
Copy Markdown
Contributor Author

@hramos please review and merge. I think that we can optimize CI cache and save some time for developers once merged.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 13, 2018
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

@dulmandakh merged commit ba608a2 into facebook:master.


Once this commit is added to a release, you will see the corresponding version tag below the description at ba608a2. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 13, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 13, 2018
@dulmandakh dulmandakh deleted the native-deps-versions branch October 15, 2018 16:26
kelset pushed a commit that referenced this pull request Oct 23, 2018
Summary:
This PR tries to consolidate Android native dependencies versions to make it less error prone to version bumps.
Pull Request resolved: #20742

Differential Revision: D9818155

Pulled By: hramos

fbshipit-source-id: 9bf631640910edad5731014f4e23dbca45af2b59
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
This PR tries to consolidate Android native dependencies versions to make it less error prone to version bumps.
Pull Request resolved: facebook#20742

Differential Revision: D9818155

Pulled By: hramos

fbshipit-source-id: 9bf631640910edad5731014f4e23dbca45af2b59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants