ios-simulator: change default iphone version#21148
Closed
vcapretz wants to merge 1 commit intofacebook:masterfrom
Closed
ios-simulator: change default iphone version#21148vcapretz wants to merge 1 commit intofacebook:masterfrom
vcapretz wants to merge 1 commit intofacebook:masterfrom
Conversation
this is just a suggestion, but as the iPhone 6 is discontinued by Apple and the new iPhone line will match the X version, it could be good to update the default simulator. it could also be the iPhone 8, feel free to suggest other changes!
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: iOS
Contributor
|
Thanks for the PR. Let's go with iPhone X for now, as it's supported by both Xcode 9.4 and Xcode 10. Once we drop support for Xcode 9, we can use iPhone XS or iPhone XR as the default. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 18, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
Vitor Capretz merged commit 6d09df5 into Once this commit is added to a release, you will see the corresponding version tag below the description at 6d09df5. If the commit has a single |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: this is just a suggestion, but as the iPhone 6 is discontinued by Apple and the new iPhone line will match the X version, it could be good to update the default simulator. it could also be the iPhone 8, feel free to suggest other changes! Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook/react-native#21148 Differential Revision: D9928120 Pulled By: hramos fbshipit-source-id: 005faa3a8e00b67f98a778c92ecc01b064e14199
grabbou
pushed a commit
that referenced
this pull request
Oct 11, 2018
Summary: this is just a suggestion, but as the iPhone 6 is discontinued by Apple and the new iPhone line will match the X version, it could be good to update the default simulator. it could also be the iPhone 8, feel free to suggest other changes! Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: #21148 Differential Revision: D9928120 Pulled By: hramos fbshipit-source-id: 005faa3a8e00b67f98a778c92ecc01b064e14199
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: this is just a suggestion, but as the iPhone 6 is discontinued by Apple and the new iPhone line will match the X version, it could be good to update the default simulator. it could also be the iPhone 8, feel free to suggest other changes! Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook#21148 Differential Revision: D9928120 Pulled By: hramos fbshipit-source-id: 005faa3a8e00b67f98a778c92ecc01b064e14199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is just a suggestion, but as the iPhone 6 is discontinued by Apple
and the new iPhone line will match the X version, it could be good to update the default simulator.
it could also be the iPhone 8, feel free to suggest other changes!
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CATEGORY] [TYPE] [LOCATION] - Message