Fix ListEmptyComponent is rendered upside down when using inverted flag.#21496
Fix ListEmptyComponent is rendered upside down when using inverted flag.#21496hyochan wants to merge 2 commits intofacebook:masterfrom react-native-seoul:master
Conversation
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
Generated by 🚫 dangerJS |
|
It looks some tests are failing, can you add the release notes and rebase your PR? |
|
Ping @dooboolab – do you mind following up and rebasing this diff, and possibly adding a test to make sure this is properly working? Then I can quickly land it :) |
|
@dooboolab You already added the release notes in the first comment of this PR, after the "fixed" screenshot :) We changed slightly the wording for it, so I think that you should change to this:
BTW I think you, instead of rebasing your PR, merged |
|
@kelset I thanks for the review. Sorry that I've had a mistake with the rebase. @benevbright found my mistake earlier and made the fix on this. By the way, very fast review. |
|
Looks good! Thanks @dooboolab |
|
@facebook-github-bot shipit |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dooboolab merged commit 198eb02 into |
Fix ListEmptyComponent is rendered upside down when using inverted flag.
Fixes #21196
Test Plan:
Try
FlatListwithinvertedflag like below.Previous result:

Fixed result:

Release Notes:
[General] [Fixed] - Fix ListEmptyComponent is rendered upside down when using inverted flag.