[TimerMixin] Removing TimerMixin on SwipeableRow#21499
Closed
gvarandas wants to merge 5 commits intofacebook:masterfrom
Closed
[TimerMixin] Removing TimerMixin on SwipeableRow#21499gvarandas wants to merge 5 commits intofacebook:masterfrom
gvarandas wants to merge 5 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
changed the title
Collaborator
|
@gvarandas merged commit de416e7 into |
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to facebook#21485. Removed TimerMixin from the SwipeableRow component since it is currently not used. Added a test case for `SwipeableRow` animation in the `SwipeableListViewSimpleExample`, by adding the `bounceFirstRowOnMount` prop, to check for any runtime issues with the setTimeout method. - [x] `npm run prettier` - [x] `npm run flow-check-ios` - [x] `npm run flow-check-android` - [x] runtime tests using `SwipeableFlatListExample` on Android and iOS - [x] runtime tests using `SwipeableListViewSimpleExample` on Android and iOS **RNTester steps** - [x] Run RNTester. - [x] Navigate to `SwipeableFlatListExample` and check if the `_animateBounceBack` animation executes when the `shouldBounceOnMount` props is passed. - [x] Swipe the row and check if the events ran correctly - [x] Navigate to `SwipeableListViewSimpleExample` and check if the `_animateBounceBack` animation executes when the `shouldBounceOnMount` props is passed. - [x] Swipe the row and check if the events ran correctly [GENERAL] [ENHANCEMENT] [Libraries/Experimental/SwipeableRow/SwipeableRow.js] - remove TimerMixin dependency [GENERAL] [ENHANCEMENT] [RNTester/js/SwipeableListViewSimpleExample.js] - Add bounceFirstRowOnMount to guarantee the SwipeableRow correct behavior. Pull Request resolved: facebook#21499 Reviewed By: TheSavior Differential Revision: D10218361 Pulled By: RSNara fbshipit-source-id: c8e6d5ced4c1237e48bb4c43592016684b2c6360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21485.
Removed TimerMixin from the SwipeableRow component since it is currently not used.
Added a test case for
SwipeableRowanimation in theSwipeableListViewSimpleExample, by adding thebounceFirstRowOnMountprop, to check for any runtime issues with the setTimeout method.Test Plan
npm run prettiernpm run flow-check-iosnpm run flow-check-androidSwipeableFlatListExampleon Android and iOSSwipeableListViewSimpleExampleon Android and iOSRNTester steps
SwipeableFlatListExampleand check if the_animateBounceBackanimation executes when theshouldBounceOnMountprops is passed.SwipeableListViewSimpleExampleand check if the_animateBounceBackanimation executes when theshouldBounceOnMountprops is passed.Release Notes
[GENERAL] [ENHANCEMENT] [Libraries/Experimental/SwipeableRow/SwipeableRow.js] - remove TimerMixin dependency
[GENERAL] [ENHANCEMENT] [RNTester/js/SwipeableListViewSimpleExample.js] - Add bounceFirstRowOnMount to guarantee the SwipeableRow correct behavior.