Remove AndroidManifest.xml from UIManager#22044
Closed
radeno wants to merge 2 commits intofacebook:masterfrom
Closed
Remove AndroidManifest.xml from UIManager#22044radeno wants to merge 2 commits intofacebook:masterfrom
radeno wants to merge 2 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
dulmandakh
approved these changes
Nov 2, 2018
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 2, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: AndroidManifest.xml file in UIManager only defines minimum SDK version for whole namespace "com.facebook". But it is always redefined by build.gradle file because Gradle file has precedence. https://github.com/facebook/react-native/blob/master/ReactAndroid/build.gradle#L273 Anyway Gradle is prefered way to define it. So i think it should be removed if it is not used for another purpose. Pull Request resolved: facebook#22044 Differential Revision: D12898251 Pulled By: hramos fbshipit-source-id: 087b5cc45495109b5626c9cb232d0546c53fb709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AndroidManifest.xml file in UIManager only defines minimum SDK version for whole namespace "com.facebook". But it is always redefined by build.gradle file because Gradle file has precedence.
https://github.com/facebook/react-native/blob/master/ReactAndroid/build.gradle#L273
Anyway Gradle is prefered way to define it. So i think it should be removed if it is not used for another purpose.
Test Plan:
CI green
Release Notes:
[INTERNAL] [BUGFIX] [com.facebook.react.uimanager] - Removed AndroidManifest.xml from UIManager in advantage of build.grafle.