Skip to content

[Lean Core] Add deprecation warning for status-bar#23898

Closed
dmtrKovalenko wants to merge 1 commit intofacebook:masterfrom
dmtrKovalenko:patch-1
Closed

[Lean Core] Add deprecation warning for status-bar#23898
dmtrKovalenko wants to merge 1 commit intofacebook:masterfrom
dmtrKovalenko:patch-1

Conversation

@dmtrKovalenko
Copy link
Copy Markdown
Contributor

@dmtrKovalenko dmtrKovalenko commented Mar 13, 2019

Summary

Adds a deprecation warning for using status-bar package

Lean Core Issue: #23313

Changelog

[General] [Deprecated] - Deprecated StatusBar as it has now been moved to @react-native-community/statusbar

Test Plan

Open the RNTester app to the StatusBar examples and see the deprecation warning yellow box.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dmtrKovalenko dmtrKovalenko mentioned this pull request Mar 13, 2019
64 tasks
@dmtrKovalenko
Copy link
Copy Markdown
Contributor Author

I have signed CLA

@pull-bot
Copy link
Copy Markdown

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 5433ee9

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ericlewis
Copy link
Copy Markdown
Contributor

@dmtrKovalenko can you double check your Changelog? Seems to mention NetInfo instead.

@dmtrKovalenko
Copy link
Copy Markdown
Contributor Author

@ericlewis Fixed

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your work on this :)

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @dmtrKovalenko in 7fd5320.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 15, 2019
grabbou pushed a commit that referenced this pull request Mar 15, 2019
Summary:
Adds a deprecation warning for using status-bar package

Lean Core Issue: #23313

[General] [Deprecated] - Deprecated StatusBar as it has now been moved to react-native-community/statusbar
Pull Request resolved: #23898

Differential Revision: D14477606

Pulled By: cpojer

fbshipit-source-id: 2955374446f879c3e7cfea97cb8c379ec8b003cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Deprecation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants