Skip to content

Add tests for utilities#23989

Closed
casperboone wants to merge 10 commits intofacebook:masterfrom
cafejojo:utilities-tests
Closed

Add tests for utilities#23989
casperboone wants to merge 10 commits intofacebook:masterfrom
cafejojo:utilities-tests

Conversation

@casperboone
Copy link
Copy Markdown
Contributor

Summary

This PR add tests for several utilities in Libraries/Utilities, as a follow-up of #23903.

The following utilities are now tested:

  • clamp.js
  • binareToBase64.js
  • DeviceInfo.js
  • mergeIntoFast.js
  • PixelRatio.js
  • infoLog.js
  • logError.js
  • warnOnce.js
  • mapWithSeparator (added a missing test)

Changelog

Not applicable, since it only adds tests.

Test Plan

This is a testing PR, so I do not believe that is necessary :)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2019
@pull-bot
Copy link
Copy Markdown

pull-bot commented Mar 17, 2019

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against b5f0653

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work! Thank you so much for this.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @casperboone in f541c34.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants