Resolve Promise to YES for Linking.openURL

[thib92]

Summary

The Linking.openURL() method is supposed to resolve to a true Promise when the URL was properly open. However, in iOS, the Promise was resolving to nil. So I fixed this issue by making it resolve to YES (true), just like on Android.

Changelog

[iOS] [Fixed] - Fix return value of Linking.openURL()

Test Plan

Create a sample app, and use the Linking API to open a URL (I use Uber deeplinks: uber://, following
their deep-links docs). Make sure that the Promise resolves to true on the JS side.

With the code from the version I use for my project (0.59.1), I received undefined. With these changes, I received true on the JS side.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[cpojer]

Thank you!

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @thib92 in 4a5d0bd.

^{When will my fix make it into a release? | Upcoming Releases}