[RN][CI] Configure E2E tests to run on a commit that contains #run-e2e-tests#41308
Closed
cipolleschi wants to merge 3 commits intomainfrom
Closed
[RN][CI] Configure E2E tests to run on a commit that contains #run-e2e-tests#41308cipolleschi wants to merge 3 commits intomainfrom
cipolleschi wants to merge 3 commits intomainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 5a7ae61 |
cipolleschi
force-pushed
the
cipolleschi/e2e-enable-on-commit
branch
from
fa6e4c3 to
8ff4cf8
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/e2e-enable-on-commit
branch
from
8ff4cf8 to
8f146c4
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cipolleschi in bb4e940. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
@cipolleschi merged this pull request in bb4e940. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
Summary: #41308 introduce the possibility to run e2e tests if a commit contains #run-e2e-tests in the commit message. This PR builds on top of that, and let users to run e2e tests by adding a comment with with #run-e2e-tests ## Changelog: [Internal] - Allow to run e2e tests from comments Pull Request resolved: #41311 Test Plan: Not sure it can be tested until the PR is merged... ¯\_(ツ)_/¯ Reviewed By: dmytrorykun Differential Revision: D51111543 Pulled By: cipolleschi fbshipit-source-id: e6c55950552f03830fa35c89d385ab9b17f8facb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change allow our CI to run E2E tests using a specific tag in the commit message
Changelog:
[Internal] - Allow to run e2e test using a specific tag in the last commit message
Test Plan:
CircleCI is green
Tested interacting with the PR/branch