allow use without @react-native-community/cli-server-api#45311
Closed
blakef wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
Base commit: 2eb7bcb |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
3 similar comments
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
Summary: Removing the remaining dependencies from the react-native-community/*. This inlines a copy of the logger. Changelog: [Internal][Changed] Removed react-native-community/cli-tools logger dependency Differential Revision: D59378011
Summary: Removed the use of version checking and error code that is in react-native-community/cli-tools. Changelog: [Internal] [Changed] - Removed community-cli-plugin version & error dependencies Differential Revision: D59378012
Summary: Pull Request resolved: #45311 Allows Gradle and Xcode builds to continue without the rnc dependency. Differential Revision: D59377223
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59377223 |
Contributor
|
This pull request has been merged in 24997dc. |
|
This pull request was successfully merged by @blakef in 24997dc When will my fix make it into a release? | How to file a pick request? |
blakef
added a commit
that referenced
this pull request
Nov 6, 2024
When decoupling the community-cli-plugin from the @react-native-community/cli-server-api (#45311), a middleware stub was created to allow a runtime stub to be used in this case. This middleware should be used so as not to break when the optional cli-server-api dependency isn't present. Changelog: [General][Fix] - Fix npm react-native start when cli-server-api isn't installed Testing: Forced a runtime exception simulating the package not being dependent and was able to build rn-tester.
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Summary: When decoupling the community-cli-plugin from the react-native-community/cli-server-api (#45311), a middleware stub was created to allow a runtime stub to be used in this case. This middleware should be used so as not to break when the optional cli-server-api dependency isn't present. Changelog: [General][Fixed] - Fix npm react-native start when cli-server-api isn't installed Pull Request resolved: #47450 Test Plan: Forced a runtime exception simulating the package not being dependent and was able to build rn-tester.  Reviewed By: cipolleschi Differential Revision: D65532486 Pulled By: blakef fbshipit-source-id: 2b380607de63ac2da906ef0cb1e48b9ef263cb68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Allows Gradle and Xcode builds to continue without the rnc dependency.
Differential Revision: D59377223