feat(image): [android] adding only-if-cached cache control option#47348
Closed
mateoguzmana wants to merge 5 commits into
Closed
feat(image): [android] adding only-if-cached cache control option#47348mateoguzmana wants to merge 5 commits into
only-if-cached cache control option#47348mateoguzmana wants to merge 5 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Abbondanzo
requested changes
Nov 1, 2024
Contributor
Abbondanzo
left a comment
Abbondanzo
left a comment
There was a problem hiding this comment.
A few nits that let Fresco make more of the decisions here
…ext to disk check
…droid-option-adjustments Feat/image only if cached android option adjustments
Abbondanzo
requested changes
Nov 1, 2024
Contributor
Abbondanzo
left a comment
Abbondanzo
left a comment
There was a problem hiding this comment.
Left a comment in our chain about request levels, that should be the simpler approach
Abbondanzo
approved these changes
Nov 2, 2024
Contributor
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@Abbondanzo merged this pull request in dc9db01. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in dc9db01 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
) Summary: This PR follows up on #47182 and #47348 by adding `force-cache`, the final missing option to align caching controls with the existing behavior on iOS. Local caching behavior remains unchanged: if a cached image is available locally, it will be returned; otherwise, a network request will be made. When an image request is sent over the network, the `force-cache` option sent from the sent fJS side will now use the `okhttp3.CacheControl.FORCE_CACHE` directive. ## Changelog: [ANDROID] [ADDED] - Image `force-cache` caching control option Pull Request resolved: #47426 Test Plan: New example added to the RNTester under the cache policy examples. Then inspecting that the cache control is set correctly before sending it in the `okhttp3.Request` builder. ```kt FLog.w("ReactNative", "fetching uri: %s, with cacheControl: %s", uri, cacheControlBuilder.build().toString()) // fetching uri: https:...png?cacheBust=force-cache, with cacheControl: no-store, max-stale=2147483647, only-if-cached ``` This case was a bit more tricky to test in terms of e2e as it would involve some caching in the server as well, I'm open to suggestions to make this more complete. Reviewed By: javache Differential Revision: D65490360 Pulled By: Abbondanzo fbshipit-source-id: f807a9793f85caea39c59a370d057b9a1d450a78
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…ts (#47953) Summary: This is a follow up for the new cache control options for the Android Image component introduced in #47182, #47348 & #47426. And to make sure the cache control header works as expected and avoid missing the issue fixed in #47922, this PR introduces test cases to make sure this is getting applied as expected in the `ReactOkHttpNetworkFetcher`. ## Changelog: [INTERNAL] [ADDED] - `ReactOkHttpNetworkFetcher` cache control tests Pull Request resolved: #47953 Test Plan: ```bash yarn test-android ``` Reviewed By: rshest Differential Revision: D66498305 Pulled By: javache fbshipit-source-id: 7a9a0cc596e49964943e59189614743ca8a472a1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Following up from #47182, as basic caching control is already in place in Android, it can be extended to include the
only-if-cachedoption.We check whether the image is in the cache. If it is, we proceed to load it. Otherwise, we do nothing.
Changelog:
[ANDROID] [ADDED] - Image
only-if-cachedcache control optionTest Plan:
In the
rn-tester, I added a third example for Android where the third image will never be loaded as the cache policy is set toonly-if-cachedand the image has not been loaded before.Video demonstrating how the `only-if-cached` options behaves
Screen.Recording.2024-10-31.at.23.57.04.mov
Error from image not found in cache example