test(image): [android] improving image property test cases#47433
Closed
mateoguzmana wants to merge 1 commit into
Closed
test(image): [android] improving image property test cases#47433mateoguzmana wants to merge 1 commit into
mateoguzmana wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
cortinico
approved these changes
Nov 6, 2024
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Amazing stuff @mateoguzmana !
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 17c1646. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 17c1646 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
…47527) Summary: Follow up from #47433, adding some missing scenarios in the unit tests for the image component in Android. ## Changelog: [INTERNAL] [ADDED] - Improving Android `ImageResizeMode` unit tests Pull Request resolved: #47527 Test Plan: ```bash yarn test-android ``` Reviewed By: fabriziocucci Differential Revision: D65735794 Pulled By: Abbondanzo fbshipit-source-id: a420274c78d9eadf0439870cfaae4d16247c6034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've doing some enhancements around the Image component for Android, and in the process of understanding the codebase I saw some opportunity to improve the test cases as there is no much coverage around the underlying functionality.
Changelog:
[INTERNAL] [ADDED] - Improving Android Image property test cases
Test Plan: