[0.76] Skip hermes-parser under Babel for non-Flow JS code#47569
Merged
blakef merged 1 commit intofacebook:0.76-stablefrom Nov 13, 2024
Merged
[0.76] Skip hermes-parser under Babel for non-Flow JS code#47569blakef merged 1 commit intofacebook:0.76-stablefrom
blakef merged 1 commit intofacebook:0.76-stablefrom
Conversation
facebook-github-bot
added
CLA Signed
blakef
approved these changes
Nov 12, 2024
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves facebook/hermes#1549.
babel-plugin-syntax-hermes-parserto0.15.1(including newparseLangTypesoption Skip plugin for non-Flow JS code hermes#1556).parseLangTypesin@react-native/babel-preset.Changelog:
[General][Fixed] - When using Babel with plain JavaScript files, support for additional user syntax plugins should be fixed (now uses Babel's parser instead of hermes-parser). There is no change for JS files annotated with
@flow, where extended JS syntax remains unsupported.Test Plan
[Meta only] See Phabricator test plan attached to facebook/hermes#1556.
See also hermes-parser changelog — no anticipated incompatibilities from single package bump.