-
Notifications
You must be signed in to change notification settings - Fork 25.1k
react-native link works incorrect #18333
Copy link
Copy link
Closed
Labels
Impact: RegressionDescribes a behavior that used to work on a prior release, but stopped working recently.Describes a behavior that used to work on a prior release, but stopped working recently.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Metadata
Metadata
Assignees
Labels
Impact: RegressionDescribes a behavior that used to work on a prior release, but stopped working recently.Describes a behavior that used to work on a prior release, but stopped working recently.Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Type
Fields
Give feedbackNo fields configured for issues without a type.
After merging #17961
react-native linkcommand works wrong.Before,
paramsfield was used only for android and waiting for user response, now it uses for all platforms without waiting user input.Seem like that main reason it's that you doesn't work with promises and just use
Object.keys().forEach(link)Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.1
Yarn: 0.15.1
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.1 => 0.54.1
Expected Behavior
platformfield for filter purposeActual Behavior
I've got duplicate questions in terminal, "postinstall" script runs before user set up params
Steps to Reproduce
$ react-native init AwesomeProject $ cd AwesomeProject $ npm i react-native-code-push --save $ react-native link react-native-code-pushSo we'll get mess in terminal