Move execution of ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() out of destructor #46993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
mdvacca
force-pushed
the
export-D64190029
branch
from
8a40818 to
939da9f
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 12, 2024
…iews() out of destructor (facebook#46993) Summary: Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native. We are moving this call into the contructor of the object which always happen on the js thread changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D64190029
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 12, 2024
…iews() out of destructor (facebook#46993) Summary: Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native. We are moving this call into the contructor of the object which always happen on the js thread changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D64190029
mdvacca
force-pushed
the
export-D64190029
branch
from
939da9f to
0ce7706
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 12, 2024
…iews() out of destructor (facebook#46993) Summary: Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native. We are moving this call into the contructor of the object which always happen on the js thread changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D64190029
mdvacca
force-pushed
the
export-D64190029
branch
from
0ce7706 to
955b9ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 12, 2024
…iews() out of destructor (facebook#46993) Summary: Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native. We are moving this call into the contructor of the object which always happen on the js thread changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D64190029
mdvacca
force-pushed
the
export-D64190029
branch
from
955b9ca to
3557848
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
…iews() out of destructor (facebook#46993) Summary: Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native. We are moving this call into the contructor of the object which always happen on the js thread changelog: [internal] internal Reviewed By: rubennorte Differential Revision: D64190029
mdvacca
force-pushed
the
export-D64190029
branch
from
3557848 to
c4a4c1d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64190029 |
|
This pull request has been merged in 3443127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Calling ReactNativeFeatureFlags::enableDeletionOfUnmountedViews() from the destructor increases the chance of accessing ReactNativeFeatureFlags during the tear down of React Native.
We are moving this call into the contructor of the object which always happen on the js thread
changelog: [internal] internal
Reviewed By: rubennorte
Differential Revision: D64190029