Fix binary size regression for BackgroundImage #54126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Oct 13, 2025
Summary: The binary size for RN builds increased by ~180KiB due to the implementation of the `experimental_backgroundImage` property diffing. This diff removes default inlining for the `toDynamic` serialization functions of the structs used by the linear and radial gradient styles. Combined with the binary size improvements done previously for `ColorStop` and `ValueUnit`, the binary size has been reduced by 176.0KiB Changelog: [Internal] Reviewed By: javache Differential Revision: D84214151
lenaic
force-pushed
the
export-D84214151
branch
from
4d9a881 to
d17fe22
Compare
added 2 commits
October 14, 2025 05:31
…ebook#54125) Summary: With ColorStop and ValueUnit being used at multiple locations, inlining the `toDynamic` conversion used for RN Android and using `std::format` to convert floating point values to string increased the binary size of RN Android by ~180KiB. This diff declares the functions outside the header to avoid inlining the functions and removes the dependency on `std::format` for the percent value string formatting. Changelog: [Internal] Reviewed By: javache Differential Revision: D84349391
Summary: The binary size for RN builds increased by ~180KiB due to the implementation of the `experimental_backgroundImage` property diffing. This diff removes default inlining for the `toDynamic` serialization functions of the structs used by the linear and radial gradient styles. Combined with the binary size improvements done previously for `ColorStop` and `ValueUnit`, the binary size has been reduced by 176.0KiB Changelog: [Internal] Reviewed By: javache Differential Revision: D84214151
lenaic
force-pushed
the
export-D84214151
branch
from
d17fe22 to
e6c3136
Compare
|
This pull request has been merged in 93278d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The binary size for RN builds increased by ~180KiB due to the implementation of the
experimental_backgroundImageproperty diffing.This diff removes default inlining for the
toDynamicserialization functions of the structs used by the linear and radial gradient styles.Combined with the binary size improvements done previously for
ColorStopandValueUnit, the binary size has been reduced by 176.0KiBChangelog: [Internal]
Differential Revision: D84214151