Pass view.width / .height to image prefetcher, needed for correct resource prefetching #54546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87083726. |
meta-cla
bot
added
the
CLA Signed
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
…ource prefetching (facebook#54546) Summary: Changelog: [Internal] We need to forward the `imageView` width and height to the prefetcher to correctly handle resize requests Differential Revision: D87083726
christophpurrer
force-pushed
the
export-D87083726
branch
from
c32571d to
64c1e0c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2025
…ource prefetching (facebook#54546) Summary: Changelog: [Internal] We need to forward the `imageView` width and height to the prefetcher to correctly handle resize requests Differential Revision: D87083726
christophpurrer
force-pushed
the
export-D87083726
branch
from
64c1e0c to
54c8123
Compare
Summary: Changelog: [Internal] Currently these default values https://reactnative.dev/docs/image#resizemethod-android https://reactnative.dev/docs/image#resizemultiplier-android are not correctly treated in C++ code as parsing bails out here: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/propsConversions.h#L176-L177 By setting default values in the struct, we can fix it Reviewed By: sbuggay Differential Revision: D87083023
…ource prefetching (facebook#54546) Summary: Changelog: [Internal] We need to forward the `imageView` width and height to the prefetcher to correctly handle resize requests Reviewed By: sbuggay Differential Revision: D87083726
christophpurrer
force-pushed
the
export-D87083726
branch
from
54c8123 to
61c2b3d
Compare
|
This pull request has been merged in c2623af. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in c2623af When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
…ource prefetching (#54546) Summary: Pull Request resolved: facebook/react-native#54546 Changelog: [Internal] We need to forward the `imageView` width and height to the prefetcher to correctly handle resize requests Reviewed By: sbuggay Differential Revision: D87083726 fbshipit-source-id: 8abfc7702e79ac8ad254229391ca1259fd1f5b47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
We need to forward the
imageViewwidth and height to the prefetcher to correctly handle resize requestsDifferential Revision: D87083726