Store entire build directory as CI artifacts#15310
Merged
acdlite merged 3 commits intofacebook:masterfrom Apr 4, 2019
Merged
Conversation
Updates the Circle CI config to store Facebook bundles as build artifacts. We already do this for our npm packages.
acdlite
changed the title
bvaughn
reviewed
Apr 3, 2019
Contributor
There was a problem hiding this comment.
Might as well store entire
build/directory
I think we should use a similar approach as pack_and_store_artifact.sh that just packs up the FB facebook-www into a TGZ so that we have a single thing to download and extract during our sync, rather than each of these individual ones
So it's easy to download
Collaborator
Author
|
Good call |
Collaborator
Author
|
@bvaughn Ok it now stores the |
facebook-github-bot
added
the
React Core Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Circle CI config to store Facebook bundles as build artifacts. We already do this for our npm packages.
Update: Might as well store entire
build/directory