Feature request: react-hooks/exhaustive-deps option to require deps arg.

[ryandagg]

Please add an option to the configuration for the react-hooks/exhaustive-deps eslint rule to require a deps argument for all hooks that can take it.

This new configuration option would throw a warning/error (don't care about default) for the code below:

const Demo = ({ thing }) => {
  useEffect(() => {
    console.log(thing)
  })
}

I am aware that this already throws an error:

const Demo = ({ thing }) => {
  useEffect(() => {
    console.log(thing)
  }, [])
}

This request is specifically concerning the case where no second argument is passed to hooks like useEffect, useCallback, useMemo, etc.

The configuration would be used in a way similar to this:
'react-hooks/exhaustive-deps': ['warn', {alwaysRequireDeps: true }]

Reasoning:
I can't think of a scenario where firing the callback of useEffect on every render is desired. An intentional eslint-disable-next-line is acceptable if this scenario arises.
A missing deps arg can cause sneaky bugs.

[rjgotten]

I can't think of a scenario where firing the callback of useEffect on every render is desired.

Let me provide one then:
I have a custom hook that implements roving tab-index behavior for keyboard-navigating list-like ARIA roles such as toolbar. It is attached to elements through a register function returned from the hook, which takes a key:Key argument to facilitate a map of refs it internally uses, since it can collect an arbitrary number. (Pretty common pattern.)

For the order of the rovable items, accessibility best-practice is to retain DOM order. So that's what this hook does. To prevent any out-of-orderness in assignment of ref-ed elements into the weak it internally uses Node.compareDocumentPosition to get them into document order.

You could just compute that on keydown. Every time. But it's expensive.
So instead, you really want to precompute that once.

Which has to be done from an effect -- more precisely: a layout effect -- after every render, when refs have been reassigned.