Conversation
We don't need to wait for it to be labeled now that we have the shared maintainer check workflow.
github-actions
Bot
added
the
React Core Team
|
Comparing: 989b0cccc215e5c4692552b0cc01d23938dcf99b...a0e4b748de4c1597f7fac92b5528fef4e6ca68cf Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
added a commit
that referenced
this pull request
Feb 7, 2025
There's no real reason to have 2 jobs for sizebot. It's more of a historical artifact from before the GH migration. Merging them should require one less worker needing to be provisioned and some of the extra overhead --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32333). * __->__ #32333 * #32332
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Feb 9, 2025
Follow-up for facebook#32332. The Discord webhook seems to ignore draft PRs, which is a good thing. But when a draft PR is then later set to "ready for review" we do want to send another notification that should then not be filtered out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to wait for it to be labeled now that we have the shared maintainer check workflow.
Stack created with Sapling. Best reviewed with ReviewStack.