Unknown plugin babel-plugin-transform-react-jsx-source

[keyz]

#6398 added babel-preset-react/node_modules/babel-plugin-transform-react-jsx-source to .babelrc, but babel-preset-react doesn't export this module. npm run build and npm test fail because of that.

I removed this line from .babelrc and #6398's tests still pass. Should I remove it or change it to just babel-plugin-transform-react-jsx-source? @troydemonbreun @jimfb

Also cc @spicyj since you might know this issue.

[sophiebits]

Probably should just be babel-plugin-transform-react-jsx-source or transform-react-jsx-source but I'm confused why the test would be passing even without it. Do you want to look into that @keyanzhang?

[keyz]

This is really weird -- my build fails both on master and that commit. Could you reproduce this (locally and on travis)? @spicyj

[sophiebits]

Haven't tried locally. Travis is broken trying to calculate coverage (unrelated) but the jest tests themselves appear to pass:

https://travis-ci.org/facebook/react/jobs/127678860

[keyz]

Oh I figured out. It fails on npm3 but not npm2, since npm2 doesn't flatten deps. Out travis build only runs on npm2. babel-plugin-transform-react-jsx-source is a dependency of babel-preset-react.

I can do a PR to change .babelrc but I don't need if we actually need this plugin.

[sophiebits]

Got it. Let's add an explicit dep in package.json and change .babelrc to reference it directly (don't need the babel-plugin- prefix in .babelrc).