Skip to content

Revert "Remove setProps and replaceProps completely"#7039

Merged
zpao merged 1 commit intomasterfrom
revert-6921-remove-set-props-and-replace-props
Jun 14, 2016
Merged

Revert "Remove setProps and replaceProps completely"#7039
zpao merged 1 commit intomasterfrom
revert-6921-remove-set-props-and-replace-props

Conversation

@zpao
Copy link
Copy Markdown
Member

@zpao zpao commented Jun 14, 2016

Reverts #6921

#6921 (comment) explains why.

// _renderValidatedComponent) assume that calls to render aren't nested;
// verify that that's the case. (This is called by each top-level update
// function, like setState, forceUpdate, etc.; creation and
// function, like setProps, setState, forceUpdate, etc.; creation and
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. why should it be here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original commit removed it so reverting that re-added it.

@gaearon gaearon deleted the revert-6921-remove-set-props-and-replace-props branch January 5, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants