Remove setProps and replaceProps completely#6921
Merged
jimfb merged 1 commit intofacebook:masterfrom Jun 9, 2016
Merged
Conversation
ghost
added
koba04
force-pushed
the
remove-set-props-and-replace-props
branch
from
878b55a to
bbf9ef8
Compare
|
@koba04 updated the pull request. |
| ReactDOM.render( | ||
| <TestComponent stateListener={stateListener} nextColor="green" />, | ||
| container, | ||
| instance.peekAtCallback('setProps') |
Contributor
There was a problem hiding this comment.
I don't think we want to remove this one. This isn't actually the same as the setProps that you removed elsewhere.
koba04
force-pushed
the
remove-set-props-and-replace-props
branch
from
bbf9ef8 to
dd739f8
Compare
|
@koba04 updated the pull request. |
jimfb
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
Contributor
|
Ok, this looks good, thanks @koba04! |
Contributor
Author
|
Thank you! |
Member
|
Sorry to do this, but I'm going to revert this. Can you submit separate PRs for the changes to |
Contributor
Author
|
Thank you, I got it! |
This was referenced Jun 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setPropsandreplacePropsare removed completely on v15.0