Merged
Conversation
ghost
added
Incrementally type ReactInstance by adding the types of attach/detachRef. I moved isValidOwner as a function inside of the file since it's never used externally.
| * @return {boolean} True if `object` is a valid owner. | ||
| * @final | ||
| */ | ||
| function isValidOwner(object: any): bool { |
Contributor
There was a problem hiding this comment.
Would you want to use 'mixed' here rather than 'any'?
Contributor
Author
There was a problem hiding this comment.
The only call site of this function gives a variable of type ReactInstance, so if we follow the type system, this function is always going to return true and the invariant is dead code.
The only reason this function exists is that the entire code base is not respecting the type system. So adding a type mixed or any isn't going to make any difference :)
If you insist, I can change it to mixed, I don't really mind
Contributor
There was a problem hiding this comment.
Don't worry about it since it makes no difference in this case - thanks for explaining. :)
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
Incrementally type ReactInstance by adding the types of attach/detachRef. I moved isValidOwner as a function inside of the file since it's never used externally. (cherry picked from commit fa9869b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementally type ReactInstance by adding the types of attach/detachRef.
I moved isValidOwner as a function inside of the file since it's never used externally.