Check for event listener in props on demand instead of maintaining listener bank#8192
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Nov 8, 2016
Merged
Conversation
sophiebits
approved these changes
Nov 3, 2016
Collaborator
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
last commit lgtm, haven't reviewed controlled components
sebmarkbage
force-pushed
the
lazyeventlisteners
branch
from
e64755e to
fdc71a0
Compare
This just reads events from the props instead of storing them in a listener back. I had to rewrite a bunch of tests to cover this model. I removed the tests that just test the adding and removing over listeners since there is no equivalent behavior anymore.
sebmarkbage
force-pushed
the
lazyeventlisteners
branch
from
fdc71a0 to
43eff97
Compare
sebmarkbage
added a commit
to sebmarkbage/react
that referenced
this pull request
Nov 8, 2016
)" This reverts commit a878c30. The previous stuff that this builds on didn't successfully land fully. Since I want to measure this in isolation, I'll revert this for now.
sebmarkbage
added a commit
that referenced
this pull request
Nov 8, 2016
sebmarkbage
added a commit
to sebmarkbage/react
that referenced
this pull request
Nov 14, 2016
…cebook#8192)" (facebook#8239)" This reverts commit b2eaafa.
sebmarkbage
added a commit
that referenced
this pull request
Nov 15, 2016
* Reapply Check for event listener in props instead of bank (#8192) This reverts the previous revert. * Don't throw on falsy event listeners Some code relies on passing null. This restores the earlier behavior.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This just reads events from the props instead of storing them in a listener back. I had to rewrite a bunch of tests to cover this model. I removed the tests that just test the adding and removing over listeners since there is no equivalent behavior anymore.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
)" (facebook#8239) This reverts commit a878c30. The previous stuff that this builds on didn't successfully land fully. Since I want to measure this in isolation, I'll revert this for now.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
) * Reapply Check for event listener in props instead of bank (facebook#8192) This reverts the previous revert. * Don't throw on falsy event listeners Some code relies on passing null. This restores the earlier behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #8190, #8189 and #8176
This just reads events from the props instead of storing them in a listener back.
I had to rewrite a bunch of tests to cover this model. I removed the tests that just test the adding and removing over listeners since there is no equivalent behavior anymore.