Pass component as an argument to React.renderComponent callback

[chestozo]

There is a callback now in the React.renderComponent method.
Why not pass rendered component into this callback?

This can be useful when you want to call some component method after it was completely mounted, like this:

React.renderComponent(
  <Slider />,
  node,
  function(component) {
    component.setDataSource(data);
  }
);

[chestozo]

Because here I get null reference exception:

var slider = React.renderComponent(
  <Slider />,
  node,
  function() {
    slider.setDataSource(data); // slider is still undefined here
  }
);

because this callback is executed synchronously with the React.renderComponent method.

[chestozo]

Or, just bind callback to this component here https://github.com/facebook/react/blob/master/src/core/ReactUpdates.js#L105 like this:

callback.call(component);

But I think it is better just to pass component as an argument )

[chestozo]

I see, this callback now is executed when component was rendered and not mounted as I was expecting...

[sophiebits]

Thanks, looks like this is a bug. It should be callback.call(component); like it is earlier in that file:

https://github.com/facebook/react/blob/master/src/core/ReactUpdates.js#L67

[chestozo]

I have also noticed those but thought that it was a design decision (because this callback passed to React.renderComponent is create before component creation and those upper in the code are for batch updates).

Thanks guys for your work! I am really enjoying writing components in react )

[sophiebits]

Fixed in #876.