In SSR, Store Elements of Composites on the Stack for Warnings#10187
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Jul 19, 2017
Merged
In SSR, Store Elements of Composites on the Stack for Warnings#10187sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
sebmarkbage
commented
Jul 15, 2017
| ReactDebugCurrentFrame.getCurrentStack = getStackAddendum; | ||
| }; | ||
| var pushElementToDebugStack = function(element) { | ||
| if (currentDebugElementStack !== null) { |
Contributor
Author
There was a problem hiding this comment.
I need this null check because this reset isn't reentrant so it might be reset. See follow up in #10188
acdlite
approved these changes
Jul 15, 2017
Collaborator
acdlite
left a comment
acdlite
left a comment
There was a problem hiding this comment.
I don't have full context but this looks ok to me
In DEV mode this keeps an additional sub-stack within the stack of the server renderer. This substack keeps track of all the elements that we resolved to get to to the next processing frame. This lets us recreate the full composite component stack for warnings. Normally the stack only contains host components. We reset this every time we're going to resolve another sibling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DEV mode this keeps an additional sub-stack within the stack of the
server renderer. This substack keeps track of all the elements that we
resolved to get to to the next processing frame.
This lets us recreate the full composite component stack for warnings.
Normally the stack only contains host components.
We reset this every time we're going to resolve another sibling.