Skip to content

Fixes example in Web Components docs #11039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 2 commits into from
Oct 4, 2017
Merged

Fixes example in Web Components docs #11039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
350f117
fixes docs on webcomponent
trueadm Oct 2, 2017
130af7b
Update web-components.md
gaearon Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/docs/web-components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ function BrickFlipbox() {

## Using React in your Web Components

Similarly, you can call `ReactDOM.render()` from inside a web component:

```javascript
class XSearch {
class XSearch extends HTMLElement {
connectedCallback() {
const mountPoint = document.createElement('span');
this.attachShadow({ mode: 'open' }).appendChild(mountPoint);
Expand All @@ -54,3 +56,7 @@ class XSearch {
}
customElements.define('x-search', XSearch);
```

>Note:
>
>This code will **not** work if compiled with Babel [due to an intentional limitation in the specification](https://github.com/w3c/webcomponents/issues/587). It will only work if you use the `class` syntax directly in the browser without compiling the code first.