Skip to content

Only renderers should depend on reconciler code #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 2 commits into from
Oct 19, 2017
+7 −13
Merged

Only renderers should depend on reconciler code #11281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b903ab
Only renderers should depend on reconciler code
gaearon Oct 19, 2017
fb4f472
Remove react-art dependency on react-dom modules
gaearon Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...dom/src/shared/ReactDOMFrameScheduling.js → ...ges/shared/src/ReactDOMFrameScheduling.js
View file
Open in desktop
File renamed without changes.
0 ...econciler/src/ReactFiberTreeReflection.js → ...es/shared/src/ReactFiberTreeReflection.js
View file
Open in desktop
File renamed without changes.
4 changes: 3 additions & 1 deletion packages/shared/src/ReactInstanceMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@
* instance (key) and the internal representation (value). This allows public
* methods to accept the user facing instance as an argument and map them back
* to internal methods.
*
* Note that this module is currently shared and assumed to be stateless.
* If this becomes an actual Map, that will break.
*/

// TODO: Replace this with ES6: var ReactInstanceMap = new Map();
var ReactInstanceMap = {
/**
* This API should be called `delete` but we'd have to make sure to always
Expand Down
0 ...t-reconciler/src/ReactTypeOfSideEffect.js → packages/shared/src/ReactTypeOfSideEffect.js
View file
Open in desktop
File renamed without changes.
0 ...__tests__/ReactDOMFrameScheduling-test.js → ...__tests__/ReactDOMFrameScheduling-test.js
View file
Open in desktop
File renamed without changes.
16 changes: 4 additions & 12 deletions scripts/rollup/bundles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,7 @@ const bundles = [
label: 'test-utils',
manglePropertiesOnProd: false,
name: 'react-dom/test-utils',
paths: [
'packages/react-dom/**/*.js',
'packages/react-reconciler/**/*.js',
'packages/shared/**/*.js',
],
paths: ['packages/react-dom/**/*.js', 'packages/shared/**/*.js'],
},
/* React DOM internals required for react-native-web (e.g., to shim native events from react-dom) */
{
Expand Down Expand Up @@ -175,6 +171,7 @@ const bundles = [
name: 'react-dom/server.browser',
paths: [
'packages/react-dom/**/*.js',
// TODO: server shouldn't depend on reconciler modules:
'packages/react-reconciler/**/*.js',
'packages/shared/**/*.js',
],
Expand All @@ -199,6 +196,7 @@ const bundles = [
name: 'react-dom/server.node',
paths: [
'packages/react-dom/**/*.js',
// TODO: server shouldn't depend on reconciler modules:
'packages/react-reconciler/**/*.js',
'packages/shared/**/*.js',
],
Expand Down Expand Up @@ -234,8 +232,6 @@ const bundles = [
name: 'react-art',
paths: [
'packages/react-art/**/*.js',
// Because of DOMFrameScheduling. Should be shared?
'packages/react-dom/**/*.js',
'packages/react-reconciler/**/*.js',
'packages/shared/**/*.js',
],
Expand Down Expand Up @@ -375,11 +371,7 @@ const bundles = [
label: 'shallow-renderer',
manglePropertiesOnProd: false,
name: 'react-test-renderer/shallow',
paths: [
'packages/react-test-renderer/**/*.js',
'packages/react-reconciler/**/*.js',
'packages/shared/**/*.js',
],
paths: ['packages/react-test-renderer/**/*.js', 'packages/shared/**/*.js'],
},

/******* React Noop Renderer (used only for fixtures/fiber-debugger) *******/
Expand Down