Skip to content

Expose TapEventPlugin on the www bundle #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 1 commit into from
Oct 25, 2017
Merged

Expose TapEventPlugin on the www bundle #11360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/react-dom/index.fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@ Object.assign(ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, {
ReactFiberTreeReflection: require('shared/ReactFiberTreeReflection'),
ReactDOMComponentTree: require('./src/client/ReactDOMComponentTree'),
ReactInstanceMap: require('shared/ReactInstanceMap'),
// These are dependencies of TapEventPlugin:
EventPluginUtils: require('events/EventPluginUtils'),
EventPropagators: require('events/EventPropagators'),
SyntheticUIEvent: require('./src/events/SyntheticUIEvent'),
// Used by www msite:
TapEventPlugin: require('./src/events/TapEventPlugin'),
});

module.exports = ReactDOM;
1 change: 0 additions & 1 deletion packages/shared/describeComponentFrame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*
* @flow
* @providesModule describeComponentFrame
*/

'use strict';
Expand Down
16 changes: 1 addition & 15 deletions scripts/rollup/packaging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ const RN_DEV = Bundles.bundleTypes.RN_DEV;
const RN_PROD = Bundles.bundleTypes.RN_PROD;

const facebookWWW = 'facebook-www';
// these files need to be copied to the facebook-www build
const facebookWWWSrcDependencies = [
'packages/react-dom/src/events/TapEventPlugin.js',
];

// these files need to be copied to the react-native build
const reactNativeSrcDependencies = [
Expand Down Expand Up @@ -114,17 +110,7 @@ function createFacebookWWWBuild() {
const from = join('scripts', 'rollup', 'shims', facebookWWW);
const to = join('build', facebookWWW, 'shims');

return asyncCopyTo(from, to).then(() => {
let promises = [];
// we also need to copy over some specific files from src
// defined in facebookWWWSrcDependencies
for (const srcDependency of facebookWWWSrcDependencies) {
promises.push(
asyncCopyTo(resolve(srcDependency), join(to, basename(srcDependency)))
);
}
return Promise.all(promises);
});
return asyncCopyTo(from, to);
}

function copyBundleIntoNodePackage(packageName, filename, bundleType) {
Expand Down
12 changes: 6 additions & 6 deletions scripts/rollup/results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@
"gzip": 33563
},
"ReactDOM-dev.js (FB_DEV)": {
"size": 587573,
"gzip": 134618
"size": 590443,
"gzip": 135554
},
"ReactDOM-prod.js (FB_PROD)": {
"size": 418348,
"gzip": 92934
"size": 420794,
"gzip": 93574
},
"react-dom-test-utils.development.js (NODE_DEV)": {
"size": 41554,
Expand Down Expand Up @@ -101,8 +101,8 @@
"gzip": 5899
},
"ReactDOMServer-dev.js (FB_DEV)": {
"size": 93943,
"gzip": 25012
"size": 93901,
"gzip": 25000
},
"ReactDOMServer-prod.js (FB_PROD)": {
"size": 42426,
Expand Down
17 changes: 0 additions & 17 deletions scripts/rollup/shims/facebook-www/EventPropagators.js
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions scripts/rollup/shims/facebook-www/SyntheticUIEvent.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...up/shims/facebook-www/EventPluginUtils.js → ...llup/shims/facebook-www/TapEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @providesModule EventPluginUtils
* @providesModule TapEventPlugin
*/

'use strict';
Expand All @@ -14,4 +14,4 @@ const {
} = require('ReactDOM-fb');

module.exports =
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.EventPluginUtils;
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.TapEventPlugin;