Auto-install (or update) release script Yarn deps before running#11434
Merged
bvaughn merged 1 commit intofacebook:masterfrom Nov 2, 2017
Merged
Auto-install (or update) release script Yarn deps before running#11434bvaughn merged 1 commit intofacebook:masterfrom
bvaughn merged 1 commit intofacebook:masterfrom
Conversation
gaearon
approved these changes
Nov 2, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
If you can verify failing Yarn also fails the build, seems good.
Contributor
Author
|
Yah. Changing the command to Thanks~ |
5 tasks
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stepping through a dry-run of the new release process for
16.1.0-betaand realized that there was no guaranteed that we were running the latest version of the release script dependencies.