switch ordering of logical and#11462
Merged
gaearon merged 1 commit intofacebook:masterfrom Nov 5, 2017
Merged
Conversation
gaearon
approved these changes
Nov 5, 2017
Collaborator
|
I think this is good. Let's wait for CI to pass. |
Contributor
Author
gaearon
reviewed
Nov 5, 2017
| } | ||
|
|
||
| if (lowerCasedName.indexOf('on') === 0 && lowerCasedName.length > 2) { | ||
| if (lowerCasedName.length > 2 && lowerCasedName.indexOf('on') === 0) { |
Collaborator
There was a problem hiding this comment.
This one is not necessary. We're guarding against [] access outside of bounds in particular. Here it doesn't happen.
Contributor
Author
There was a problem hiding this comment.
I see. Sorry I accidentally messes up with the git, should I squash them?
Collaborator
There was a problem hiding this comment.
Doesn't matter, we squash on merge anyway.
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11460