Performance tool: Warn when interrupting an in-progress tree#11480
Merged
acdlite merged 2 commits intofacebook:masterfrom Nov 7, 2017
Merged
Performance tool: Warn when interrupting an in-progress tree#11480acdlite merged 2 commits intofacebook:masterfrom
acdlite merged 2 commits intofacebook:masterfrom
Conversation
acdlite
commented
Nov 7, 2017
| warning = 'Interrupted an in-progress update'; | ||
| } else if (commitCountInCurrentWorkLoop > 1) { | ||
| warning = 'There were cascading updates'; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@gaearon Wasn't sure what to do here. Should we show both warnings? How should they be formatted?
Collaborator
There was a problem hiding this comment.
Maybe show more important one? There's not much screen space there.
acdlite
force-pushed
the
warnoninterruptions
branch
from
cc5ea67 to
c65a6a0
Compare
Collaborator
|
Is interrupting always bad? |
Collaborator
Author
|
Not necessarily, though neither are cascading updates. Maybe we should add a different type of label formatted for non-scary information? |
Collaborator
Author
|
An example of something that's always bad is expiration. |
gaearon
reviewed
Nov 7, 2017
|
|
||
| export function startWorkLoopTimer(): void { | ||
| export function startWorkLoopTimer(nextUnitOfWork: Fiber | null): void { | ||
| currentFiber = nextUnitOfWork; |
Collaborator
There was a problem hiding this comment.
This should be inside the if (enableUserTimingAPI) check.
acdlite
force-pushed
the
warnoninterruptions
branch
from
bdbe678 to
30b5334
Compare
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
…k#11480) * Performance tool: Warn when interrupting an in-progress tree * Include the name of the component that caused the interruption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning to the performance tool when an in-progress update is interrupted by equal or higher priority work.