Measure time between scheduling an async callback and flushing it#11506
Measure time between scheduling an async callback and flushing it#11506acdlite merged 3 commits intofacebook:masterfrom
Conversation
There was a problem hiding this comment.
Failing some tests on CI + probably need to update prettier.
Typo: https://github.com/acdlite/react/blob/3888bbc15a73d67f0a1a0def041942bc1e248e8b/packages/react-reconciler/src/ReactFiberScheduler.js#L1434 (deadlne) :P
| } | ||
|
|
||
| export function startRequestCallbackTimer(): void { | ||
| if (enableUserTimingAPI && !isWaitingForCallback) { |
There was a problem hiding this comment.
Can we keep this nested? I want to keep all top level conditions uniform so it's obvious they all have to include the enableUserTimingAPI flag check.
| exports[`ReactDebugFiberPerf captures all lifecycles 1`] = ` | ||
| "// Mount | ||
| "⚛ (Waiting for async callback...) | ||
| // Mount |
There was a problem hiding this comment.
These comments are a bit confusing now. They were meant to be attached to the phases below. Any way we can avoid nesting them?
acdlite
force-pushed
the
warnonexpiration
branch
from
3888bbc to
5da6b4d
Compare
| export function stopRequestCallbackTimer(didExpire: boolean): void { | ||
| if (enableUserTimingAPI) { | ||
| isWaitingForCallback = false; | ||
| const warning = didExpire ? 'Async work expired' : null; |
There was a problem hiding this comment.
Not very obvious to me what this means. Is there a way to phrase it in a more user-accessible way?
There was a problem hiding this comment.
Yeah, let's think of something better. I was trying to keep it concise. What it means is:
"An async update starved because the main thread was blocked"
acdlite
force-pushed
the
warnonexpiration
branch
from
5da6b4d to
240b858
Compare
Helps detect starvation issues.
acdlite
force-pushed
the
warnonexpiration
branch
2 times, most recently
from
1ccf6b7 to
c0a62af
Compare
|
@gaearon What if I changed it to say "Warning: Main thread is blocked"? Is that clearer? |
| `${' '.repeat(activeMeasure.indent + 1)}// ${comment}`, | ||
| ); | ||
| comments.push(comment); | ||
| // activeMeasure.children.push( |
Most users won't know what "expires" means
acdlite
force-pushed
the
warnonexpiration
branch
from
c0a62af to
f475a52
Compare
…cebook#11506) * Measure time between scheduling an async callback and flushing it Helps detect starvation issues. * Debug comments should print directly above the next measure * Better warning message Most users won't know what "expires" means
4 participants
Helps detect starvation issues.