track each individual file that has already been annotated with flow#11521
Closed
MatteoVH wants to merge 1 commit intofacebook:masterfrom
Closed
track each individual file that has already been annotated with flow#11521MatteoVH wants to merge 1 commit intofacebook:masterfrom
MatteoVH wants to merge 1 commit intofacebook:masterfrom
Conversation
Collaborator
|
I'm going on a vacation today so I won't be able to review until next week. |
Author
|
Enjoy! 😄 |
Collaborator
|
Perhaps #11545 would make more sense. |
Author
|
Yep, I think that's a much nicer format. Feel free to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A start to #11328. Specifically based on #11328 (comment). I think ideally this would be a more tabular format, but I'm not sure if it's worth breaking the previous format of single line additions. I'm open to suggestions.
It also might be nice to log files that we have left to type annotate instead of files that are already done. That way it's easier to see what work still has to be done.
The new format would look something like: