Skip to content

Remove vars #11766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 5 commits into from
Dec 5, 2017
Merged

Remove vars #11766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2f37aa
react: convert packages/react
raphamorim Dec 2, 2017
4dc0c01
react-reconciler: convert packages/react-reconciler
raphamorim Dec 2, 2017
a107353
react-noop-renderer: convert packages/react-noop-renderer
raphamorim Dec 2, 2017
1f7fc65
react-dom: convert packages/react-dom/src/shared
raphamorim Dec 2, 2017
1801eaa
react-dom: convert packages/react-dom/src/server
raphamorim Dec 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react-dom/src/server/DOMMarkupOperations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ import warning from 'fbjs/lib/warning';

// isAttributeNameSafe() is currently duplicated in DOMPropertyOperations.
// TODO: Find a better place for this.
var VALID_ATTRIBUTE_NAME_REGEX = new RegExp(
const VALID_ATTRIBUTE_NAME_REGEX = new RegExp(
'^[' + ATTRIBUTE_NAME_START_CHAR + '][' + ATTRIBUTE_NAME_CHAR + ']*$',
);
var illegalAttributeNameCache = {};
var validatedAttributeNameCache = {};
const illegalAttributeNameCache = {};
const validatedAttributeNameCache = {};
function isAttributeNameSafe(attributeName) {
if (validatedAttributeNameCache.hasOwnProperty(attributeName)) {
return true;
Expand Down Expand Up @@ -80,12 +80,12 @@ export function createMarkupForRoot() {
* @return {?string} Markup string, or null if the property was invalid.
*/
export function createMarkupForProperty(name, value) {
var propertyInfo = getPropertyInfo(name);
const propertyInfo = getPropertyInfo(name);
if (propertyInfo) {
if (shouldIgnoreValue(propertyInfo, value)) {
return '';
}
var attributeName = propertyInfo.attributeName;
const attributeName = propertyInfo.attributeName;
if (
propertyInfo.hasBooleanValue ||
(propertyInfo.hasOverloadedBooleanValue && value === true)
Expand Down
8 changes: 4 additions & 4 deletions packages/react-dom/src/server/ReactDOMStringRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import ReactPartialRenderer from './ReactPartialRenderer';
* See https://reactjs.org/docs/react-dom-server.html#rendertostring
*/
export function renderToString(element) {
var renderer = new ReactPartialRenderer(element, false);
var markup = renderer.read(Infinity);
const renderer = new ReactPartialRenderer(element, false);
const markup = renderer.read(Infinity);
return markup;
}

Expand All @@ -24,7 +24,7 @@ export function renderToString(element) {
* See https://reactjs.org/docs/react-dom-server.html#rendertostaticmarkup
*/
export function renderToStaticMarkup(element) {
var renderer = new ReactPartialRenderer(element, true);
var markup = renderer.read(Infinity);
const renderer = new ReactPartialRenderer(element, true);
const markup = renderer.read(Infinity);
return markup;
}
Loading