Highlight production bundles in bold in the Danger integration comment#12054
Highlight production bundles in bold in the Danger integration comment#12054gaearon merged 4 commits intofacebook:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| r.bundleType.includes('PROD') | ||
| ? boldRow([ | ||
| r.filename, | ||
| emojiPercent(r.prevFileSizeChange), |
There was a problem hiding this comment.
We could change signature of this to addPercent(text, includeEmoji). Because we want percent sign in both cases. This lets us make the call unconditional, with different boolean values depending on the branch. Similarly, we could have boldRow accept a boolean.
Then you could do
const isProd = r.bundleType.includes('PROD');
return setBoldness([
r.filename,
addPercent(r.prevFileSizeChange, isProd),
// ...
], isProd);and not duplicate the column list twice.
There was a problem hiding this comment.
Thanks. I have revised the codes per your comments.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| function boldRow(row) { | ||
| return row.map(element => `**${element}**`); | ||
| function setBoldness(row, isProd) { |
There was a problem hiding this comment.
Nit: this could be called isBold because this particular function cares about the formatting rather than when we make it bold
|
How can we test and verify this works? |
|
I think this looks good. Let's give it a try. Thanks! |
|
Based on what I can gather from Orta's comments, |
|
That sounds good to me, thanks. If something's wrong we'll see it anyway. 👍 |
3 participants
This PR modified Danger integration comment:
address #[12043]