Warn about unsafe toWarnDev() nesting in tests#12457
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
What's missing? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
nooooooo |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Uh, I had totally forgotten about this PR. I guess it's just those three lint rules. I could pick this back up and finish it if we think it's worth doing. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
4 similar comments
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@bvaughn you must have really knocked it out the park signing that CLA |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I signed the heck out of it |
|
Is this still active? WIP? |
|
@facebook-github-bot seems pretty active here But otherwise, no. I'd forgotten about it. |
|
FWIW I did get confused by our existing tests that had wrong nesting a few days ago. I think we should fix. |
|
I'll see if I can finish this one out then. |
|
Removed the two lint-warning-suppression comments. |
bvaughn
changed the title
| 'Use the `defaultValue` or `value` props instead of setting children on <textarea>.', | ||
| ); | ||
| }).toThrow(); | ||
| ).toThrow(); |
There was a problem hiding this comment.
While we’re at it, can we add a message here so that we don’t pass on any error?
6 participants
Resolves #12428
This is a work in progress because we have 3 tests (currently marked with ESLint suppression comments) that fail if the nesting order is reversed. (When we replay failed work, the warning is logged a second time- even though we only expect it once.)