Remove leftovers from ReactTransitionGroup rewrite#1329
Merged
zpao merged 1 commit intofacebook:masterfrom Apr 1, 2014
Merged
Conversation
Contributor
Author
|
This is failing because of master is failing. What's the proper way of handling this cases? Should I contribute based on the last Travis passing build next time? |
Collaborator
|
No problem; it's easy to see that only the immutable tests are failing. Also we'll try to keep the tree green. :) |
Contributor
Contributor
Author
|
Just did. |
Contributor
Author
|
I tried again and got "The 'Email' and 'Secondary email' and 'GitHub' values have been registered on this form before. If you would like to update an existing contributor account, please email cla@fb.com with your details." So I guess I signed =) |
Contributor
|
Sorry nvm, got it |
Member
|
Thanks! |
zpao
added a commit
that referenced
this pull request
Apr 1, 2014
Remove leftovers from ReactTransitionGroup rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like while rewriting @petehunt forgot to remove this block. See:
9ac27cb This block used to contain the only
runNextTickocurrences in the whole project. No tests broken after removal,no documentation affected.