Skip to content

Fixtures nits #13375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhunzaker merged 3 commits into from
Aug 13, 2018
Merged

Fixtures nits #13375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7154d78
fix: PropTypes failing in textarea fixtures
raunofreiberg Aug 12, 2018
e746f89
fix: Iframe title attribute in fixtures
raunofreiberg Aug 12, 2018
26d96c8
Make description a optional prop in FixtureSet
raunofreiberg Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/FixtureSet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const React = window.React;

const propTypes = {
title: PropTypes.node.isRequired,
description: PropTypes.node.isRequired,
description: PropTypes.node,
};

class FixtureSet extends React.Component {
Expand Down
1 change: 1 addition & 0 deletions fixtures/dom/src/components/Iframe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class IframePortal extends React.Component {
return (
<div>
<iframe
title="Iframe portal"
style={{border: 'none', height: this.props.height}}
ref={this.handleRef}
/>
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/buttons/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function onButtonClick() {
export default class ButtonTestCases extends React.Component {
render() {
return (
<FixtureSet title="Buttons" description="">
<FixtureSet title="Buttons">
<TestCase
title="onClick with disabled buttons"
description="The onClick event handler should not be invoked when clicking on a disabled buyaton">
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/date-inputs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const React = window.React;
class DateInputFixtures extends React.Component {
render() {
return (
<FixtureSet title="Dates" description="">
<FixtureSet title="Dates">
<TestCase title="Switching between date and datetime-local">
<TestCase.Steps>
<li>Type a date into the date picker</li>
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/error-handling/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class TriggerErrorAndCatch extends React.Component {
export default class ErrorHandlingTestCases extends React.Component {
render() {
return (
<FixtureSet title="Error handling" description="">
<FixtureSet title="Error handling">
<TestCase
title="Break on uncaught exceptions"
description="In DEV, errors should be treated as uncaught, even though React catches them internally">
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/event-pooling/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const React = window.React;
class EventPooling extends React.Component {
render() {
return (
<FixtureSet title="Event Pooling" description="">
<FixtureSet title="Event Pooling">
<MouseMove />
<Persistence />
</FixtureSet>
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/media-events/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default class MediaEvents extends React.Component {
}, {});

return (
<FixtureSet title="Media Events" description="">
<FixtureSet title="Media Events">
<TestCase
title="Event bubbling"
description="Media events should synthetically bubble">
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/mouse-events/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const React = window.React;
class MouseEvents extends React.Component {
render() {
return (
<FixtureSet title="Mouse Events" description="">
<FixtureSet title="Mouse Events">
<MouseMovement />
</FixtureSet>
);
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/password-inputs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const React = window.React;

function NumberInputs() {
return (
<FixtureSet title="Password inputs" description="">
<FixtureSet title="Password inputs">
<TestCase
title="The show password icon"
description={`
Expand Down
2 changes: 1 addition & 1 deletion fixtures/dom/src/components/fixtures/selects/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class SelectFixture extends React.Component {

render() {
return (
<FixtureSet title="Selects" description="">
<FixtureSet title="Selects">
<form className="field-group">
<fieldset>
<legend>Controlled</legend>
Expand Down