Closed
Conversation
src/core/ReactDescriptor.js
Outdated
Collaborator
|
accept I was going to do this but didn't get around to it. Fixes #1333. clowncopterize |
Contributor
|
Be careful about perf here. This is one of the most expensive code paths in dev. |
Collaborator
|
I think the only thing here that might be sketchy about perf is the creation of the |
Member
Author
|
Yea, going to move that out since it's not used every time, but this fn is called for every child ever. |
We weren't warning for key issues at the top level (renderComponent) level at all. This makes us do that, even if it's not quite perfect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't warning for key issues at the top level (renderComponent) level at
all. This makes us do that, even if it's not quite perfect.
@sebmarkbage complained to me after it went in that #1334 wasn't really the right fix (true, but it was needed).